linux-kernel - Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE

Open Source and information security mailing list archives

Message-ID: <e0ab5224-1120-4b06-b625-822491d6b926@canonical.com>
Date:   Tue, 3 Oct 2017 13:34:23 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Jérémy Lefaure <jeremy.lefaure@....epita.fr>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        devel@...ica.org
Subject: Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE

On 03/10/17 12:39, Rafael J. Wysocki wrote:
> On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote:
>> On Mon, 02 Oct 2017 14:27:52 +0200
>> "Rafael J. Wysocki" <rjw@...ysocki.net> wrote:
>>
>>> ACPICA is soewhat special code, though and I'm not taking or ACKing patches
>>> for it directly as a rule.
>>>
>>> For one, I'm not sure if ACPICA can use ARRAY_SIZE at all.
>> Why is it special code that can't use ARRAY_SIZE ? Is it because this
>> macro is defined in linux/kernel.h ?

However, ACPICA does have ACPI_ARRAY_LENGTH(x), see source/include/actypes.h

> 
> Basically, yes.
> 
> ACPICA is a separate project and the kernel acquires its source code from
> the upstream (which is used by other OSes too).  That is not the case for
> any other code in the kernel I know about.
> 
> 
> We strive to keep the ACPICA code in the kernel as close to the upstream as
> reasonably possible for maintenance reasons, so we avoid doing Linux-specific
> things in it.
> 
> As a rule of thumb, if you do cleanups like this one, better avoid the ACPICA
> code. :-)
> 
> Thanks,
> Rafael
> 
> _______________________________________________
> Devel mailing list
> Devel@...ica.org
> https://lists.acpica.org/mailman/listinfo/devel
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives