linux-kernel - Re: [PATCH 05/12] writeback: switch wakeup_flusher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171003124305.GM11879@quack2.suse.cz>
Date:   Tue, 3 Oct 2017 14:43:05 +0200
From:   Jan Kara <jack@...e.cz>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        hannes@...xchg.org, jack@...e.cz, torvalds@...ux-foundation.org
Subject: Re: [PATCH 05/12] writeback: switch wakeup_flusher_threads() to
 cyclic writeback

On Wed 27-09-17 14:13:52, Jens Axboe wrote:
> We're writing back the full range of dirty pages on the devices,
> there's no point in making this special and not do normal range
> cyclic writeback.
> 
> Signed-off-by: Jens Axboe <axboe@...nel.dk>

OK, since this is just ordinary "memory cleaning" writeback, I agree that
range_cyclic probably makes more sense. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/fs-writeback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index bb6148dc6d24..65e6992d8719 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -1971,7 +1971,7 @@ void wakeup_flusher_threads(enum wb_reason reason)
>  
>  		list_for_each_entry_rcu(wb, &bdi->wb_list, bdi_node)
>  			wb_start_writeback(wb, wb_split_bdi_pages(wb, nr_pages),
> -					   false, reason);
> +						true, reason);
>  	}
>  	rcu_read_unlock();
>  }
> -- 
> 2.7.4
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR