linux-kernel - Re: [PATCH] cpuidle: fix broadcast control when broadcast can not be entered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hE-H_RfJcb=AWyitQOzkRxf=XXC_+q1+k0b35CZFceyg@mail.gmail.com>
Date:   Tue, 3 Oct 2017 02:31:40 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Nicholas Piggin <npiggin@...il.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpuidle: fix broadcast control when broadcast can not be entered

On Fri, Sep 1, 2017 at 9:44 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Fri, 1 Sep 2017, Nicholas Piggin wrote:
>
>> When failing to enter broadcast timer mode for an idle state that
>> requires it, a new state is selected that does not require broadcast,
>> but the broadcast variable remains set. This causes
>> tick_broadcast_exit to be called despite not having entered broadcast
>> mode.
>>
>> This causes the WARN_ON_ONCE(!irqs_disabled()) to trigger in some
>> cases. It does not appear to cause problems for code today, but seems
>> to violate the interface so should be fixed.
>>
>> Signed-off-by: Nicholas Piggin <npiggin@...il.com>
>
> Reviewed-by: Thomas Gleixner <tglx@...utronix.de>

Applied, thanks!