linux-kernel - Re: [RESEND PATCH] prctl: add PR_[GS]ET_PDEATHSIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFz4FBarZhrbbASHcrS7SUgoiHh5A6t865XvA0SZyjxxnQ@mail.gmail.com>
Date:   Tue, 3 Oct 2017 09:10:04 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Jürg Billeter <j@...ron.ch>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Filipe Brandenburger <filbranden@...gle.com>,
        David Wilcox <davidvsthegiant@...il.com>, hansecke@...il.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC

On Tue, Oct 3, 2017 at 7:46 AM, Eric W. Biederman <ebiederm@...ssion.com> wrote:
>
> The process that requests the signal be sent is the process that is
> receiving the signal.  I can see a theoretical need for a permission
> check in there somewhere (especially as this persists over fork).

Note that it also persists over not just fork, but execve() too.

Yes, the signal is cleared if the e[ug]id/fs[ug]id is changed by exec,
but not (for example) if just uid is changed.

Does that matter? Probably not. But signal handling does actually
check uid, so it does actually affect signal permission checks across
execve.

I'm not entirely convinced about this patch. The parent death signal
has been problematic before, I'm not sure we want to add to the whole
situation without very strong arguments.

                    Linus