linux-kernel - Re: [PATCH] staging: fbtft: diferenciate between buffer and data types to fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171003163412.GA16638@kroah.com>
Date:   Tue, 3 Oct 2017 18:34:12 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Alfonso Lima Astor <alfonsolimaastor@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: diferenciate between buffer and data
 types to fix sparse warning

On Wed, Sep 27, 2017 at 06:16:18PM +0100, Alfonso Lima Astor wrote:
> sparse was complaning about an incorrect type cast:
> drivers/staging/fbtft/fbtft-bus.c:60:1: warning: incorrect type in assignment (different base types)
> drivers/staging/fbtft/fbtft-bus.c:60:1:    expected unsigned short [unsigned] [short] [usertype] <noident>
> drivers/staging/fbtft/fbtft-bus.c:60:1:    got restricted __be16 [usertype] <noident>
> drivers/staging/fbtft/fbtft-bus.c:60:1: warning: incorrect type in assignment (different base types)
> drivers/staging/fbtft/fbtft-bus.c:60:1:    expected unsigned short [unsigned] [short] [usertype] <noident>
> drivers/staging/fbtft/fbtft-bus.c:60:1:    got restricted __be16 [usertype] <noident>
> 
> The solution is to add an extra parameter to the macro to
> diferenciate between buffer type and data type.

Ugh, messy.  Please resend and cc: the maintainers of this driver/code
so that they can verify this is correct.  As it is, I have no way of
determining that...

thanks,

greg k-h