linux-kernel - RE: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE

Open Source and information security mailing list archives

Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E613032@ORSMSX110.amr.corp.intel.com>
Date:   Tue, 3 Oct 2017 16:38:17 +0000
From:   "Moore, Robert" <robert.moore@...el.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Colin Ian King <colin.king@...onical.com>
CC:     "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Jérémy Lefaure <jeremy.lefaure@....epita.fr>,
        "devel@...ica.org" <devel@...ica.org>
Subject: RE: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE

> -----Original Message-----
> From: Devel [mailto:devel-bounces@...ica.org] On Behalf Of Rafael J.
> Wysocki
> Sent: Tuesday, October 3, 2017 9:05 AM
> To: Colin Ian King <colin.king@...onical.com>
> Cc: Wysocki, Rafael J <rafael.j.wysocki@...el.com>; Rafael J. Wysocki
> <rjw@...ysocki.net>; Linux Kernel Mailing List <linux-
> kernel@...r.kernel.org>; ACPI Devel Maling List <linux-
> acpi@...r.kernel.org>; Jérémy Lefaure <jeremy.lefaure@....epita.fr>;
> devel@...ica.org
> Subject: Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE
> 
> On Tue, Oct 3, 2017 at 2:34 PM, Colin Ian King
> <colin.king@...onical.com> wrote:
> > On 03/10/17 12:39, Rafael J. Wysocki wrote:
> >> On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote:
> >>> On Mon, 02 Oct 2017 14:27:52 +0200
> >>> "Rafael J. Wysocki" <rjw@...ysocki.net> wrote:
> >>>
> >>>> ACPICA is soewhat special code, though and I'm not taking or ACKing
> >>>> patches for it directly as a rule.
> >>>>
> >>>> For one, I'm not sure if ACPICA can use ARRAY_SIZE at all.
> >>> Why is it special code that can't use ARRAY_SIZE ? Is it because
> >>> this macro is defined in linux/kernel.h ?
> >
> > However, ACPICA does have ACPI_ARRAY_LENGTH(x), see
> > source/include/actypes.h
> 
> Fair enough, but that cleanup should go in via ACPICA upstream anyway.
[Moore, Robert] 

This would be acceptable, as long as it will work properly in the cases that were presented earlier (using ARRAY_SIZE).

> 
> Thanks,
> Rafael
> _______________________________________________
> Devel mailing list
> Devel@...ica.org
> https://lists.acpica.org/mailman/listinfo/devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives