linux-kernel - Re: [RFC 2/5] fs: freeze on suspend and thaw on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1507060941.2567.6.camel@wdc.com>
Date:   Tue, 3 Oct 2017 20:02:22 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "pavel@....cz" <pavel@....cz>,
        "darrick.wong@...cle.com" <darrick.wong@...cle.com>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "ming.lei@...hat.com" <ming.lei@...hat.com>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "mcgrof@...nel.org" <mcgrof@...nel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "jikos@...nel.org" <jikos@...nel.org>,
        "len.brown@...el.com" <len.brown@...el.com>,
        "tytso@....edu" <tytso@....edu>
CC:     "boris.ostrovsky@...cle.com" <boris.ostrovsky@...cle.com>,
        "ONeukum@...e.com" <ONeukum@...e.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "nborisov@...e.com" <nborisov@...e.com>,
        "oleg.b.antonyan@...il.com" <oleg.b.antonyan@...il.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
        "jgross@...e.com" <jgross@...e.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "oleksandr@...alenko.name" <oleksandr@...alenko.name>,
        "todd.e.brandt@...ux.intel.com" <todd.e.brandt@...ux.intel.com>,
        "jack@...e.cz" <jack@...e.cz>
Subject: Re: [RFC 2/5] fs: freeze on suspend and thaw on resume

On Tue, 2017-10-03 at 11:53 -0700, Luis R. Rodriguez wrote:
> +static bool super_allows_freeze(struct super_block *sb)
> +{
> +	return !!(sb->s_type->fs_flags & FS_FREEZE_ON_SUSPEND);
> +}

A minor comment: if "!!" would be left out the compiler will perform the
conversion from int to bool implicitly so I propose to leave out the "!!"
and parentheses. Anyway, I agree with the approach of this patch and I think
that freezing filesystems before processes are frozen would be a big step
forward.

Bart.