linux-kernel - Re: [PATCH] ASoC: codecs: msm8916-wcd-analog: fix module autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e9c07c1-1262-9362-b867-9b0f1da42fc9@linaro.org>
Date:   Tue, 3 Oct 2017 21:43:20 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Nicolas Dechesne <nicolas.dechesne@...aro.org>,
        Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org
Cc:     linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH] ASoC: codecs: msm8916-wcd-analog: fix module autoload



On 03/10/17 10:49, Nicolas Dechesne wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo snd_soc_msm8916_analog | grep alias
> $
> 
> After this patch:
> 
> $ modinfo snd_soc_msm8916_analog | grep alias
> alias:          of:N*T*Cqcom,pm8916-wcd-analog-codecC*
> alias:          of:N*T*Cqcom,pm8916-wcd-analog-codec
> 
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@...aro.org>

Thanks for the patch

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

> ---
>   sound/soc/codecs/msm8916-wcd-analog.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index 549c269acc7d..d79e5b35e003 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -1241,6 +1241,8 @@ static const struct of_device_id pm8916_wcd_analog_spmi_match_table[] = {
>   	{ }
>   };
>   
> +MODULE_DEVICE_TABLE(of, pm8916_wcd_analog_spmi_match_table);
> +
>   static struct platform_driver pm8916_wcd_analog_spmi_driver = {
>   	.driver = {
>   		   .name = "qcom,pm8916-wcd-spmi-codec",
>