linux-kernel - Re: [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1507094490.5452.18.camel@aj.id.au>
Date:   Wed, 04 Oct 2017 15:51:30 +1030
From:   Andrew Jeffery <andrew@...id.au>
To:     Joel Stanley <joel@....id.au>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        devicetree <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rick Altherr <raltherr@...gle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Cédric Le Goater <clg@...d.org>,
        linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node

On Wed, 2017-10-04 at 14:43 +0930, Joel Stanley wrote:
> > > > > > +                     adc: adc@...e9000 {
> > > +                             compatible = "aspeed,ast2500-adc";
> > > +                             reg = <0x1e6e9000 0xb0>;
> > 
> > Did you intend to change the size cell value here? It now matches the g4, but
> > there was an explicit comment about the size for some reason in the -hunk
> > below. It's probably worth an explicit call-out if we're going to change it.
> 
> Looks ok to me.

Yeah, sorry, was looking in the wrong spot :/

Andrew
Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)