linux-kernel - Re: [Part2 Patch v4.2] crypto: ccp: Add Platform Security Processor (PSP) device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YSQ.7.76.1710041202020.19122@wniryva>
Date:   Wed, 4 Oct 2017 12:06:42 +0530 (IST)
From:   P J P <ppandit@...hat.com>
To:     Brijesh Singh <brijesh.singh@....com>
cc:     bp@...e.de, Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Gary Hook <gary.hook@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        linux-crypto@...r.kernel.org, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Part2 Patch v4.2] crypto: ccp: Add Platform Security Processor
 (PSP) device support

+-- On Mon, 2 Oct 2017, Brijesh Singh wrote --+
| +int psp_dev_init(struct sp_device *sp)
| +{
| +	struct device *dev = sp->dev;
| +	struct psp_device *psp;
| +	int ret;
| +
| +	ret = -ENOMEM;
| +	psp = psp_alloc_struct(sp);
| +	if (!psp)
| +		goto e_err;
| +
| +       sp->psp_data = psp;
| ...
| +e_err:
| +	sp->psp_data = NULL;

Needs to kfree(sp->psp_data) before setting to NULL.

--
 - P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F