linux-kernel - Re: [PATCH v2 01/16] hyper-v: trace vmbus_on_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Oct 2017 20:08:28 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>, kbuild-all@...org,
        devel@...uxdriverproject.org,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/16] hyper-v: trace vmbus_on_msg_dpc()

On Mon, 2 Oct 2017 08:18:50 +0800
kbuild test robot <lkp@...el.com> wrote:

> Hi Vitaly,
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.14-rc3 next-20170929]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Vitaly-Kuznetsov/hyper-v-trace-vmbus_on_msg_dpc/20171002-062040
> config: i386-randconfig-x017-201740 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from include/trace/define_trace.h:95:0,
>                     from drivers/hv/hv_trace.h:29,
>                     from drivers/hv/hv_trace.c:4:
>    include/trace/trace_events.h:759:13: warning: 'print_fmt_vmbus_hdr_msg' defined but not used [-Wunused-variable]
>     static char print_fmt_##call[] = print;     \
>                 ^
> >> drivers/hv/./hv_trace.h:9:1: note: in expansion of macro 'DECLARE_EVENT_CLASS'  

Interesting. I'm wondering if this happens because the class "print" is
not used.

Actually, I think the default print should be used by one event, and
if other events need to be made that change the print, it should use
the DEFINE_EVENT_PRINT()

But this may be moot because I think Stephen Hemminger made it back to
DEFINE_EVENT()s.

-- Steve


>     DECLARE_EVENT_CLASS(vmbus_hdr_msg,
>     ^~~~~~~~~~~~~~~~~~~
>    In file included from include/trace/define_trace.h:95:0,
>                     from drivers/hv/hv_trace.h:29,
>                     from drivers/hv/hv_trace.c:4:
>    include/trace/trace_events.h:363:37: warning: 'trace_event_type_funcs_vmbus_hdr_msg' defined but not used [-Wunused-variable]
>     static struct trace_event_functions trace_event_type_funcs_##call = { \
>                                         ^
> >> drivers/hv/./hv_trace.h:9:1: note: in expansion of macro 'DECLARE_EVENT_CLASS'  
>     DECLARE_EVENT_CLASS(vmbus_hdr_msg,
>     ^~~~~~~~~~~~~~~~~~~
> 
> vim +/DECLARE_EVENT_CLASS +9 drivers/hv/./hv_trace.h
> 
>      8	
>    > 9	DECLARE_EVENT_CLASS(vmbus_hdr_msg,  
>     10		TP_PROTO(const struct vmbus_channel_message_header *hdr),
>     11		TP_ARGS(hdr),
>     12		TP_STRUCT__entry(__field(unsigned int, msgtype)),
>     13		TP_fast_assign(__entry->msgtype = hdr->msgtype;),
>     14		TP_printk("msgtype=%d", __entry->msgtype)
>     15	);
>     16	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation