lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Oct 2017 18:00:15 -0700 From: sathyanarayanan kuppuswamy <sathyanarayanan.kuppuswamy@...ux.intel.com> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: Alessandro Zummo <a.zummo@...ertech.it>, "x86@...nel.org" <x86@...nel.org>, Wim Van Sebroeck <wim@...ana.be>, Ingo Molnar <mingo@...hat.com>, Alexandre Belloni <alexandre.belloni@...e-electrons.com>, Zha Qipeng <qipeng.zha@...el.com>, "H. Peter Anvin" <hpa@...or.com>, "dvhart@...radead.org" <dvhart@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, Lee Jones <lee.jones@...aro.org>, Andy Shevchenko <andy@...radead.org>, Souvik Kumar Chakravarty <souvik.k.chakravarty@...el.com>, linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Platform Driver <platform-driver-x86@...r.kernel.org>, Sathyanarayanan Kuppuswamy Natarajan <sathyaosid@...il.com> Subject: Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices Hi Andy, On 10/01/2017 07:44 AM, Andy Shevchenko wrote: > On Tue, Sep 5, 2017 at 8:37 AM, > <sathyanarayanan.kuppuswamy@...ux.intel.com> wrote: >> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com> >> >> Currently, we have lot of repetitive code in dependent device resource >> allocation and device creation handling code. This logic can be improved if >> we use MFD framework for dependent device creation. This patch adds this >> support. >> >> + punit_cell.id = -1; I will remove this line in next version. >> + return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, >> + &punit_cell, 1, NULL, 0, NULL); > IIRC you don't need to file cell ID in case of DEVID_AUTO. I am planning to use DEVID_NONE here to match the current behavior. Unless you have some concerns? > -- Sathyanarayanan Kuppuswamy Linux kernel developer
Powered by blists - more mailing lists