linux-kernel - Re: [Patch v4 12/22] CIFS: SMBD: Implement function to receive data via RDMA receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201710041733.xtKPjCGT%fengguang.wu@intel.com>
Date:   Wed, 4 Oct 2017 17:43:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Long Li <longli@...hange.microsoft.com>
Cc:     kbuild-all@...org, Steve French <sfrench@...ba.org>,
        linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>,
        Tom Talpey <ttalpey@...rosoft.com>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        Long Li <longli@...rosoft.com>
Subject: Re: [Patch v4 12/22] CIFS: SMBD: Implement function to receive data
 via RDMA receive

Hi Long,

[auto build test ERROR on cifs/for-next]
[also build test ERROR on v4.14-rc3 next-20170929]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Long-Li/CIFS-Implement-SMBDirect/20171004-165915
base:   git://git.samba.org/sfrench/cifs-2.6.git for-next
config: i386-randconfig-x005-201740 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   fs/cifs/smbdirect.c: In function 'smbd_recv_page':
>> fs/cifs/smbdirect.c:1923:15: error: implicit declaration of function 'kmap_atomic' [-Werror=implicit-function-declaration]
     to_address = kmap_atomic(page);
                  ^~~~~~~~~~~
>> fs/cifs/smbdirect.c:1923:13: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     to_address = kmap_atomic(page);
                ^
>> fs/cifs/smbdirect.c:1929:2: error: implicit declaration of function 'kunmap_atomic' [-Werror=implicit-function-declaration]
     kunmap_atomic(to_address);
     ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/kmap_atomic +1923 fs/cifs/smbdirect.c

  1901	
  1902	/*
  1903	 * Receive a page from receive reassembly queue
  1904	 * page: the page to read data into
  1905	 * to_read: the length of data to read
  1906	 * return value: actual data read
  1907	 */
  1908	int smbd_recv_page(struct smbd_connection *info,
  1909			struct page *page, unsigned int to_read)
  1910	{
  1911		int ret;
  1912		char *to_address;
  1913	
  1914		/* make sure we have the page ready for read */
  1915		ret = wait_event_interruptible(
  1916			info->wait_reassembly_queue,
  1917			info->reassembly_data_length >= to_read ||
  1918				info->transport_status != SMBD_CONNECTED);
  1919		if (ret)
  1920			return 0;
  1921	
  1922		/* now we can read from reassembly queue and not sleep */
> 1923		to_address = kmap_atomic(page);
  1924	
  1925		log_read(INFO, "reading from page=%p address=%p to_read=%d\n",
  1926			page, to_address, to_read);
  1927	
  1928		ret = smbd_recv_buf(info, to_address, to_read);
> 1929		kunmap_atomic(to_address);
  1930	
  1931		return ret;
  1932	}
  1933	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28996 bytes)