linux-kernel - Re: [BUG] scsi/fcoe: Sleep-in-atomic bugs in fcoe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171004100637.pucskthcimhhen4k@linux-x5ow.site>
Date:   Wed, 4 Oct 2017 12:06:37 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Jia-Ju Bai <baijiaju1990@....com>
Cc:     jth@...nel.org, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, fcoe-devel@...n-fcoe.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [BUG] scsi/fcoe: Sleep-in-atomic bugs in fcoe driver

On Tue, Oct 03, 2017 at 11:02:33AM +0800, Jia-Ju Bai wrote:
> According to fcoe_ctlr.c, the driver may sleep under a RCU lock,
> and the function call paths are:
> fcoe_ctlr_disc_stop_locked (acquire the RCU lock)
>   fc_rport_logoff
>     mutex_lock --> may sleep
> 
> fcoe_ctlr_vn_disc
>   fc_rport_login
>     mutex_lock --> may sleep
> 
> fcoe_ctlr_vn_age
>   fc_rport_logoff
>     mutex_lock --> may sleep
> 
> These bugs are found by my static analysis tool and my code review.
> 
> Thanks,
> Jia-Ju Bai
> 

Thanks for the report, coincidentally I have a bug report for this as well (in
a real setup not just static analysis) and gave the reporter a patch to test.
Once it's verified I'll post it here.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850