linux-kernel - Re: [PATCH] virt: Add vboxguest driver for Virtual Box Guest integration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171004101148.GA30855@kroah.com>
Date:   Wed, 4 Oct 2017 12:11:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Arnd Bergmann <arnd@...db.de>,
        Michael Thayer <michael.thayer@...cle.com>,
        "Knut St . Osmundsen" <knut.osmundsen@...cle.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virt: Add vboxguest driver for Virtual Box Guest
 integration

On Wed, Oct 04, 2017 at 11:32:23AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 03-10-17 13:41, Hans de Goede wrote:
> 
> <snip>
> 
> > > > +#define CHECK_IOCTL_IN(req)                             \
> > > > +do {                                         \
> > > > +    if ((req)->Hdr.cbIn != (sizeof((req)->Hdr) + sizeof((req)->u.In)) || \
> > > > +        (req)->Hdr.cbOut != sizeof((req)->Hdr))                 \
> > > > +        return -EINVAL;                             \
> > > > +} while (0)
> > > 
> > > Make these things functions instead of macros.
> > 
> > Turning these into functions is a good idea I will do so for v2.
> 
> Correction, I forgot that the passed in "req" macro
> argument has a different type with all the calls, so
> these cannot be changed into functions because they
> rely on sizeof on the specific type to do the size
> checks.

Don't we already have built-in checks for these types of things?  Surely
we don't require each ioctl user in the kernel to do this by
themselves...

thanks,

greg k-h