linux-kernel - Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171004104101.nhtsotudcrh4d354@gmail.com>
Date:   Wed, 4 Oct 2017 12:41:01 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     mingo@...hat.com, x86@...nel.org,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Alexei Starovoitov <ast@...com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe
 handlers


* Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Hmm, actually we can not disable jprobe, that has no separate Kconfig.
> So we need to introduce new kconfig for that.
> 
> And, there are several network protocols using jprobe to trace events.
> (e.g. NET_DCCPPROBE and NET_TCPPROBE)
> I think they need to migrate to trace-event at first.
> 
> So, how about below idea?
> 
> 1. Introduce CONFIG_JPROBE_API which only separate jprobe general parts
>      (no arch dependent code involves) and make it default n.
> 2. Mark break_handler and jprobe APIs deprecated so that no new user comes up.
> 3. migrate in-kernel jprobe user to trace-event or ftrace.
>    (may take some time)

So my suggestion would be to just return from register_jprobe() and don't register 
anything. Yes, there are usecases of jprobes in the kernel, but they all look 
pretty ancient and unused.

So let's try this for -next and see whether anyone has a real usecase. And no 
Kconfig and deprecation messages - those don't really work in practice - just 
disable the functionality and force people to (trivially) modify the source if 
they want to re-enable it.

If this is fine for a single release then we can just remove it all:

> 4. after that, we can completely remove jprobe which will be a series for
>    all archs. (or just one big patch?)

we want a series of patches - but that's for later.

Thanks,

	Ingo