linux-kernel - Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1507119529.4434.3.camel@perches.com>
Date:   Wed, 04 Oct 2017 05:18:49 -0700
From:   Joe Perches <joe@...ches.com>
To:     srinivasan <srinivasan.rns@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

On Wed, 2017-10-04 at 13:53 +0200, srinivasan wrote:
> Hi Joe,
> 
> Thanks for your responses. I have already compiled and the below is the
> logs for the same
> 
> Please let me know if am I missing/doing wrong

Your commit message is incomplete.

checkpatch is a guide, but it's not what you should be
describing here.

What whould be in the commit message is that these externs
are unnecessary as they are done via #include of
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h

Also, your patch is not comprehensive.
Please remove the unnecessary externs from all uses:

drivers/staging/rtl8723bs/core/rtw_wlan_util.c:extern unsigned char RTW_WPA_OUI[];

And that file has the odd and conflicting

static unsigned char WPA_TKIP_CIPHER[4] = {0x00, 0x50, 0xf2, 0x02};
[]
extern unsigned char WPA_TKIP_CIPHER[4];

Where the extern is also unnecessary.

cheers, Joe