linux-kernel - Re: [PATCH] x86/kvm: Move kvm_fastop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171004153610.b2vuraixglgqbfz6@treble>
Date:   Wed, 4 Oct 2017 10:36:10 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/kvm: Move kvm_fastop_exception to .fixup section

On Wed, Oct 04, 2017 at 08:16:36AM -0700, Guenter Roeck wrote:
> On Wed, Oct 04, 2017 at 09:43:06AM -0500, Josh Poimboeuf wrote:
> > When compiling the kernel with the '-frecord-gcc-switches' flag, objtool
> > complains:
> > 
> >   arch/x86/kvm/emulate.o: warning: objtool: .GCC.command.line+0x0: special: can't find new instruction
> > 
> > And also the kernel fails to link.
> > 
> > The problem is that the 'kvm_fastop_exception' code gets placed into the
> > throwaway '.GCC.command.line' section instead of '.text'.
> > 
> > Exception fixup code is conventionally placed in the '.fixup' section,
> > so put it there where it belongs.
> > 
> > Reported-and-tested-by: Guenter Roeck <linux@...ck-us.net>
> > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> 
> Thanks!

I forgot to add the kvm maintainers to CC.  Will resend.

-- 
Josh