linux-kernel - Re: [PATCH] ktest: take submenu into account

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171004113926.0d0a560f@gandalf.local.home>
Date:   Wed, 4 Oct 2017 11:39:26 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Satoru Takeuchi <satoru.takeuchi@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ktest: take submenu into account

On Fri, 22 Sep 2017 13:38:19 +0900
Satoru Takeuchi <satoru.takeuchi@...il.com> wrote:

> grub-reboot selects the submenu's first menuentry (title is "1>0") rather than ktest's
> menuentry (title is "2") by mistake.
> 
> ===
> $ sudo cat /boot/grub/grub.cfg  | grep -E "^menuentry|^submenu"
> ...
> menuentry 'Ubuntu' --class ubuntu --class gnu-linux --class gnu --class os $menuentry_id_option '...' {
> ...
> submenu 'Advanced options for Ubuntu' $menuentry_id_option '...' {
> ...
> menuentry 'ktest' {
> ...
> ===
> 
> Correct it by taking submenu entries into account in get_grub2_index().
> 
> Signed-off-by: Satoru Takeuchi <satoru.takeuchi@...il.com>

Thanks for sending this. I was traveling (Embedded and Kernel Recipes)
and just saw this email now. I'll add it to my priority todo list. I'll
look at it and if all goes well, it should make the next merge window.

-- Steve

> ---
>  tools/testing/ktest/ktest.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
> index 0c8b61f..6cf135a 100755
> --- a/tools/testing/ktest/ktest.pl
> +++ b/tools/testing/ktest/ktest.pl
> @@ -1821,7 +1821,7 @@ sub get_grub2_index {
>  	    $grub_number++;
>  	    $found = 1;
>  	    last;
> -	} elsif (/^menuentry\s/) {
> +	} elsif (/^menuentry\s|^submenu\s/) {
>  	    $grub_number++;
>  	}
>      }