linux-kernel - Re: [PATCH v7 2/2] tracing: Add support for preempt and irq enable/disable events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171004160434.hfd7rbefqvi3lz22@hirez.programming.kicks-ass.net>
Date:   Wed, 4 Oct 2017 18:04:34 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Joel Fernandes <joelaf@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v7 2/2] tracing: Add support for preempt and irq
 enable/disable events

On Fri, Sep 29, 2017 at 02:22:45PM -0700, Joel Fernandes wrote:
> +++ b/kernel/trace/trace_irqsoff.c

>  EXPORT_SYMBOL(trace_hardirqs_on);
>  EXPORT_SYMBOL(trace_hardirqs_off);
>  EXPORT_SYMBOL(trace_hardirqs_on_caller);
>  EXPORT_SYMBOL(trace_hardirqs_off_caller);

Steve, how does this compiler with lockdep enabled? Because:

kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_on_caller);
kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_on);
kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_off_caller);
kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_off);