lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 04 Oct 2017 19:21:08 +0300 From: Luciano Coelho <luciano.coelho@...el.com> To: Christoph Böhmwalder <christoph@...hmwalder.at>, johannes.berg@...el.com, emmanuel.grumbach@...el.com, kvalo@...eaurora.org Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 0/3] iwlwifi: cosmetic fixes On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > Fix several code style issues, some of which were reported by > checkpatch.pl. > > The changes are: > * One instance of an `int` variable being used in a boolean context, > chaned to > use the more appropriate `bool` type. > * One very minor fix, removing a newline between a function > definition and its > associated `static` keyword > * One fix wrapping a macro in curly braces > > > Christoph Böhmwalder (3): > wireless: iwlwifi: use bool instead of int > wireless: iwlwifi: function definition cosmetic fix > wireless: iwlwifi: wrap macro into braces > > drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +- > drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 16 +++++++------ > --- > 2 files changed, 8 insertions(+), 10 deletions(-) Sorry, but this kind of series just generates churn. Especially when 2 out of 3 patches are broken. I applied your previous patch because it was really trivial, but I really don't want to encourage this kind of drive-by "fixes" that only cause additional work. I generally only accept this kind of changes when people are changing code close or related to it. -- Luca.
Powered by blists - more mailing lists