linux-kernel - Re: [PATCH 1/8] ARM: dts: aspeed: Move pinctrl subnodes to improve readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 04 Oct 2017 14:00:22 +1030
From:   Andrew Jeffery <andrew@...id.au>
To:     Joel Stanley <joel@....id.au>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Cc:     Russell King <linux@...linux.org.uk>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Rick Altherr <raltherr@...gle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Cédric Le Goater <clg@...d.org>,
        linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH 1/8] ARM: dts: aspeed: Move pinctrl subnodes to improve
 readability

On Thu, 2017-09-28 at 17:21 +0930, Joel Stanley wrote:
> > From: Andrew Jeffery <andrew@...id.au>
> 
> Moving the subnodes out of the pinctrl node declaration to a reference
> allows easier access to the remaining parts of the devicetree.
> 
> > Signed-off-by: Andrew Jeffery <andrew@...id.au>
> > Reviewed-by: Xo Wang <xow@...gle.com>
> > Signed-off-by: Joel Stanley <joel@....id.au>
> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 1483 ++++++++++++++++++------------------
>  arch/arm/boot/dts/aspeed-g5.dtsi | 1549 +++++++++++++++++++-------------------
>  2 files changed, 1518 insertions(+), 1514 deletions(-)

I hate the way the diff came out for the g5, it's almost impossible to
read. Also not sure how useful it is to ack my own patch, but given the
rebasing it has suffered:

Acked-by: Andrew Jeffery <andrew@...id.au>

Cheers,

Andrew
Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)