linux-kernel - Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1507142443.46071.0.camel@redhat.com>
Date:   Wed, 04 Oct 2017 14:40:43 -0400
From:   Doug Ledford <dledford@...hat.com>
To:     Colin King <colin.king@...onical.com>,
        Lijun Ou <oulijun@...wei.com>,
        Wei Hu <xavier.huwei@...wei.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        linux-rdma@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status
 value

On Fri, 2017-09-29 at 21:13 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized
> value in ret is being returned by function hns_roce_v2_query_qp.
> Fix this by setting ret to 0 for this specific return condition.
> 
> Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks, applied.

-- 
Doug Ledford <dledford@...hat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD