linux-kernel - Re: [PATCH] arm64: Enforce endianness build flags for LD and AS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Oct 2017 11:41:35 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     Will Deacon <will.deacon@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH] arm64: Enforce endianness build flags for LD and AS

On Wed, Oct 04, 2017 at 11:31:08AM -0700, Guenter Roeck wrote:
> On Tue, Oct 03, 2017 at 01:58:22PM -0700, Guenter Roeck wrote:
> > If LD or AS is specified on the command line using "make LD=<my-ld>",
> > the endianness flag will not be added. Depending on the toolchain used,
> > this can result in endianness mismatch errors, such as
> > 
> > aarch64-cros-linux-gnu/binutils-bin/2.27.0/ld.bfd.real:
> > arch/arm64/crypto/.tmp_aes-ce-cipher.o:
> > 	compiled for a big endian system and target is little endian
> > 
> > The problem was observed when using the Chrome OS build system (which sets
> > LD on the command line) for an arm64:allmodconfig build.
> > 
> > Use the override flag for both LD and AS to ensure that the endianness
> > flag is always set.
> > 
> > Cc: Douglas Anderson <dianders@...omium.org>
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> 
> Please ignore this patch for now; it doesn't help with my problem. Not yet
> sure what happens, but it appears that "-EB" doesn't make it into the LD
> variable used by cmd_make_builtin in scripts/Makefile.build. I'll have
> to figure out what is going on.
> 
Yes, the problem is that the gcc in the Chrome OS toolchain doesn't tell
the linker which endianness to use (ie it doesn't translate -mbig-endian 
into a linker flag). Please forget this patch, it doesn't solve anything.
Sorry for the noise.

Guenter