linux-kernel - Re: [PATCH v3 16/33] tracing: Generalize per-element hist trigger data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1507144946.14461.19.camel@tzanussi-mobl.amr.corp.intel.com>
Date:   Wed, 04 Oct 2017 14:22:26 -0500
From:   Tom Zanussi <tom.zanussi@...ux.intel.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     tglx@...utronix.de, mhiramat@...nel.org, namhyung@...nel.org,
        vedang.patel@...el.com, bigeasy@...utronix.de,
        joel.opensrc@...il.com, joelaf@...gle.com,
        mathieu.desnoyers@...icios.com, baohong.liu@...el.com,
        rajvi.jingar@...el.com, linux-kernel@...r.kernel.org,
        linux-rt-users@...r.kernel.org
Subject: Re: [PATCH v3 16/33] tracing: Generalize per-element hist trigger
 data

On Wed, 2017-10-04 at 13:34 -0400, Steven Rostedt wrote:
> On Fri, 22 Sep 2017 14:59:56 -0500
> Tom Zanussi <tom.zanussi@...ux.intel.com> wrote:
> 
> > @@ -1742,7 +1746,8 @@ static void hist_trigger_stacktrace_print(struct seq_file *m,
> >  			seq_printf(m, "%s: [%llx] %-55s", field_name,
> >  				   uval, str);
> >  		} else if (key_field->flags & HIST_FIELD_FL_EXECNAME) {
> > -			char *comm = elt->private_data;
> > +			struct hist_elt_data *elt_data = elt->private_data;
> 
> Weren't we going to add a "if (WARN_ON_ONCE(!elt_data)) return;" here?
> 

This I did miss, will update ;-)

Tom

> -- Steve
> 
> > +			char *comm = elt_data->comm;
> >  
> >  			uval = *(u64 *)(key + key_field->offset);
> >  			seq_printf(m, "%s: %-16s[%10llu]", field_name,
> > --