linux-kernel - Re: [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171004214432.20833a0ff3b9c8fdced2ebaa@gmail.com>
Date:   Wed, 4 Oct 2017 21:44:32 +0200
From:   Alexander Sverdlin <alexander.sverdlin@...il.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-cris-kernel@...s.com,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Gregory Clement <gregory.clement@...e-electrons.com>,
        Jesper Nilsson <jesper.nilsson@...s.com>,
        Krzysztof Halasa <khalasa@...p.pl>,
        Mikael Starvik <starvik@...s.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/5] cris: nand: Delete an error message for a failed
 memory allocation in crisv32_nand_flash_probe()

Hello Markus,

On Wed, 4 Oct 2017 20:45:14 +0200
SF Markus Elfring <elfring@...rs.sourceforge.net> wrote:

> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.

what exactly has the software detected?
I cannot find, how this error is reported otherwise, it seems
to me that the message is not that superflous.

The patches 2..4 look to me as an exercise without any practical meaning.
Indeed, that's not how new code should be posted, but if we start
rewriting all the legacy code, this will produce huge and completely
unnecessary patch traffic.

> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 2 --
>  arch/cris/arch-v32/drivers/mach-fs/nandflash.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> index 925a98eb6d68..259aa1f46fbe 100644
> --- a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> +++ b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> @@ -136,8 +136,6 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
>  	/* Allocate memory for MTD device structure and private data */
>  	wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
>  	if (!wrapper) {
> -		printk(KERN_ERR "Unable to allocate CRISv32 NAND MTD "
> -			"device structure.\n");
>  		err = -ENOMEM;
>  		return NULL;
>  	}
> diff --git a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> index 53b56a429dde..1baf16ee74e8 100644
> --- a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> +++ b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> @@ -111,8 +111,6 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
>  	/* Allocate memory for MTD device structure and private data */
>  	wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
>  	if (!wrapper) {
> -		printk(KERN_ERR "Unable to allocate CRISv32 NAND MTD "
> -			"device structure.\n");
>  		err = -ENOMEM;
>  		return NULL;
>  	}

-- 
Alexander Sverdlin.