linux-kernel - Re: [PATCH] [STABLE-4.4, 3.18]: fix xen_swiotlb_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Oct 2017 22:15:09 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Stefano Stabellini <sstabellini@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, stable@...r.kernel.org,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        xen-devel@...ts.xenproject.org, jgross@...e.com, krzk@...nel.org,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        David Vrabel <david.vrabel@...rix.com>,
        Stefano Stabellini <stefano.stabellini@...citrix.com>,
        Andrii Anisov <andrii_anisov@...m.com>,
        Oleksandr Dmytryshyn <oleksandr.dmytryshyn@...ballogic.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [STABLE-4.4, 3.18]: fix xen_swiotlb_dma_mmap prototype

On Wed, Oct 04, 2017 at 10:01:26AM -0700, Stefano Stabellini wrote:
> On Wed, 4 Oct 2017, Arnd Bergmann wrote:
> > xen_swiotlb_dma_mmap was backported from v4.10, but older
> > kernels before commit 00085f1efa38 ("dma-mapping: use unsigned long
> > for dma_attrs") use a different signature:
> > 
> > arm/xen/mm.c:202:10: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   .mmap = xen_swiotlb_dma_mmap,
> >           ^~~~~~~~~~~~~~~~~~~~
> > arm/xen/mm.c:202:10: note: (near initialization for 'xen_swiotlb_dma_ops.mmap')
> > 
> > This adapts the patch to the old calling conventions.
> > 
> > Fixes: 2f0b82b1b830 ("swiotlb-xen: implement xen_swiotlb_dma_mmap callback")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@...nel.org>

Thanks, I've added this tag to the patch.

greg k-h