linux-kernel - Re: [PATCH] fix security_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.21.1710050910300.28944@namei.org>
Date:   Thu, 5 Oct 2017 09:10:58 +1100 (AEDT)
From:   James Morris <jmorris@...ei.org>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
cc:     Casey Schaufler <casey@...aufler-ca.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Serge Hallyn <serge@...lyn.com>,
        James Morris <james.l.morris@...cle.com>,
        LSM List <linux-security-module@...r.kernel.org>,
        Stephen Smalley <sds@...ho.nsa.gov>
Subject: Re: [PATCH] fix security_release_secctx seems broken

On Wed, 4 Oct 2017, Konstantin Khlebnikov wrote:

> Just "getcap /bin/ping" is enough to tigger leak if file has capabilities.
> Selinux shouldn't be loaded because its release_secctx hook call kfree.

Ahh, makes sense.

> 
> But sometimes it takes some time for kmemleak to find leak. Presumably
> because stale poiner stays on stack which could be reused nowdays.

Thanks for finding this!


-- 
James Morris
<jmorris@...ei.org>