linux-kernel - Re: [PATCH v2 2/9] ARM: dts: aspeed: Reorder ADC node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1507159910.5452.34.camel@aj.id.au>
Date:   Thu, 05 Oct 2017 10:01:50 +1030
From:   Andrew Jeffery <andrew@...id.au>
To:     Joel Stanley <joel@....id.au>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Cc:     Russell King <linux@...linux.org.uk>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Rick Altherr <raltherr@...gle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Cédric Le Goater <clg@...d.org>,
        linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH v2 2/9] ARM: dts: aspeed: Reorder ADC node

On Wed, 2017-10-04 at 17:19 +1030, Joel Stanley wrote:
> We try to keep the nodes in address order. The ADC node was out of
> place.
> 
> Signed-off-by: Joel Stanley <joel@....id.au>

Reviewed-by: Andrew Jeffery <andrew@...id.au>

> 
> ---
> v2:
>  - Don't introduce new clk bindings
> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 16 ++++++++--------
>  arch/arm/boot/dts/aspeed-g5.dtsi | 16 ++++++++--------
>  2 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index 1edd0cee6221..c2d96b8a5065 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -129,6 +129,14 @@
>  				};
>  			};
>  
> +			adc: adc@...e9000 {
> +				compatible = "aspeed,ast2400-adc";
> +				reg = <0x1e6e9000 0xb0>;
> +				clocks = <&clk_apb>;
> +				#io-channel-cells = <1>;
> +				status = "disabled";
> +			};
> +
>  			sram@...20000 {
>  				compatible = "mmio-sram";
>  				reg = <0x1e720000 0x8000>;	// 32K
> @@ -227,14 +235,6 @@
>  				no-loopback-test;
>  				status = "disabled";
>  			};
> -
> -			adc: adc@...e9000 {
> -				compatible = "aspeed,ast2400-adc";
> -				reg = <0x1e6e9000 0xb0>;
> -				clocks = <&clk_apb>;
> -				#io-channel-cells = <1>;
> -				status = "disabled";
> -			};
>  		};
>  	};
>  };
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index f56dd67efa50..9e71c2dac0ba 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -173,6 +173,14 @@
>  				reg-io-width = <4>;
>  			};
>  
> +			adc: adc@...e9000 {
> +				compatible = "aspeed,ast2500-adc";
> +				reg = <0x1e6e9000 0xb0>;
> +				clocks = <&clk_apb>;
> +				#io-channel-cells = <1>;
> +				status = "disabled";
> +			};
> +
>  			sram@...20000 {
>  				compatible = "mmio-sram";
>  				reg = <0x1e720000 0x9000>;	// 36K
> @@ -307,14 +315,6 @@
>  				no-loopback-test;
>  				status = "disabled";
>  			};
> -
> -			adc: adc@...e9000 {
> -				compatible = "aspeed,ast2500-adc";
> -				reg = <0x1e6e9000 0xb0>;
> -				clocks = <&clk_apb>;
> -				#io-channel-cells = <1>;
> -				status = "disabled";
> -			};
>  		};
>  	};
>  };
Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)