linux-kernel - Re: [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1507174911.4472.3.camel@canonical.com>
Date:   Thu, 05 Oct 2017 11:41:51 +0800
From:   Shrirang Bagul <shrirang.bagul@...onical.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bjørn Mork <bjorn@...k.no>
Subject: Re: [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819

On Tue, 2017-10-03 at 15:37 +0200, Johan Hovold wrote:
> On Fri, Sep 29, 2017 at 12:39:51PM +0800, Shrirang Bagul wrote:
> > Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74
> > series which will by default boot with vid 0x413c and pid's 0x81cf,
> > 0x81d0, 0x81d1,0x81d2.
> > 
> > Signed-off-by: Shrirang Bagul <shrirang.bagul@...onical.com>
> 
> Now applied.
Thank you.
> 
> Don't you want to add these to qmi_wwan as well?
I haven't tested these devices with qmi_wwan. Perhaps a separate patch once it's
verified.
> 
> > ---
> >  drivers/usb/serial/qcserial.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> > index ebc0beea69d6..eb9928963a53 100644
> > --- a/drivers/usb/serial/qcserial.c
> > +++ b/drivers/usb/serial/qcserial.c
> > @@ -174,6 +174,10 @@ static const struct usb_device_id id_table[] = {
> >  	{DEVICE_SWI(0x413c, 0x81b3)},	/* Dell Wireless 5809e Gobi(TM) 4G
> > LTE Mobile Broadband Card (rev3) */
> >  	{DEVICE_SWI(0x413c, 0x81b5)},	/* Dell Wireless 5811e QDL */
> >  	{DEVICE_SWI(0x413c, 0x81b6)},	/* Dell Wireless 5811e QDL */
> > +	{DEVICE_SWI(0x413c, 0x81cf)},   /* Dell Wireless 5819 */
> > +	{DEVICE_SWI(0x413c, 0x81d0)},   /* Dell Wireless 5819 */
> > +	{DEVICE_SWI(0x413c, 0x81d1)},   /* Dell Wireless 5818 */
> > +	{DEVICE_SWI(0x413c, 0x81d2)},   /* Dell Wireless 5818 */
> >  
> >  	/* Huawei devices */
> >  	{DEVICE_HWI(0x03f0, 0x581d)},	/* HP lt4112 LTE/HSPA+ Gobi 4G
> > Modem (Huawei me906e) */
> 
> Thanks,
> Johan