linux-kernel - Re: [PATCH] ALSA: sh: aica: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h60but8pb.wl-tiwai@suse.de>
Date:   Thu, 05 Oct 2017 08:22:40 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Kees Cook" <keescook@...omium.org>
Cc:     <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>,
        "Bhumika Goyal" <bhumirks@...il.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Jaroslav Kysela" <perex@...ex.cz>
Subject: Re: [PATCH] ALSA: sh: aica: Convert timers to use timer_setup()

On Thu, 05 Oct 2017 02:53:36 +0200,
Kees Cook wrote:
> 
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly. This requires adding a pointer to
> hold the timer's target substream, as there won't be a way to pass this in
> the future.
> 
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.com>
> Cc: Bhumika Goyal <bhumirks@...il.com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: alsa-devel@...a-project.org
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> This requires commit 686fef928bba ("timer: Prepare to change timer
> callback argument type") in v4.14-rc3, but should be otherwise
> stand-alone.

The conversions look straightforward, so I'm going to apply it (and
other two you posted).  But now I wonder why only three were chosen.
Will you keep working on the rest usages in sound/*, or would you
expect us doing the rest?


thanks,

Takashi