linux-kernel - Re: [PATCH] drm/i915/selftests: fix check for intel IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <150720583160.27301.1046928525658527290@mail.alporthouse.com>
Date:   Thu, 05 Oct 2017 13:17:11 +0100
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Arnd Bergmann <arnd@...db.de>,
        "Jani Nikula" <jani.nikula@...ux.intel.com>,
        "Joonas Lahtinen" <joonas.lahtinen@...ux.intel.com>,
        "Rodrigo Vivi" <rodrigo.vivi@...el.com>,
        "David Airlie" <airlied@...ux.ie>
Cc:     "Arnd Bergmann" <arnd@...db.de>,
        "Matthew Auld" <matthew.auld@...el.com>,
        "Tvrtko Ursulin" <tvrtko.ursulin@...el.com>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915/selftests: fix check for intel IOMMU

Quoting Arnd Bergmann (2017-10-05 13:07:22)
> An earlier bugfix tried to work around this build failure:
> 
> drivers/gpu/drm/i915/selftests/mock_gem_device.c: In function 'mock_gem_device':
> drivers/gpu/drm/i915/selftests/mock_gem_device.c:151:20: error: 'struct dev_archdata' has no member named 'iommu'
> 
> Checking for CONFIG_IOMMU_API is not sufficient as a compile-time
> test since that may be enabled in configurations that have neither
> INTEL_IOMMU not AMD_IOMMU enabled. This changes the check to
> INTEL_IOMMU instead, as this is the only case we actually care about.
> 
> Fixes: f46f156ea770 ("drm/i915/selftests: Only touch archdata.iommu when it exists")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I'll take your wisdom. I was lost trying to nail down exactly what
config options we needed to check and settled for something that
appeared good enough (for the small selection of configs I tested).

Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>
-Chris