linux-kernel - Re: [PATCH v2] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171005123459.3m53oolhizgpug5o@mwanda>
Date:   Thu, 5 Oct 2017 15:34:59 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Srishti Sharma <srishtishar@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        outreachy-kernel@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: rtl8188eu: core: rtw_mlme_ext: Use
 list_for_each_entry_safe

On Wed, Oct 04, 2017 at 10:46:56PM +0530, Srishti Sharma wrote:
>  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> index 52f31c7..4e1d06c 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> @@ -5446,6 +5446,7 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned char *pbuf)
>  
>  u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf)
>  {
> +	struct xmit_frame *tmp;
>  	if (send_beacon(padapter) == _FAIL) {

You need a blank line between the declaration and the code.

regards,
dan carpenter