linux-kernel - Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1507208633.4434.24.camel@perches.com>
Date:   Thu, 05 Oct 2017 06:03:53 -0700
From:   Joe Perches <joe@...ches.com>
To:     Srinivasan Shanmugam <srinivasan.rns@...il.com>,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

On Thu, 2017-10-05 at 13:28 +0200, Srinivasan Shanmugam wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"

Subject and commit message don't match

> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
[]
> @@ -1227,7 +1227,7 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_
>  union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame);
>  
>  static sint validate_recv_mgnt_frame(struct adapter *padapter,
> -				    union recv_frame *precv_frame)
> +				     union recv_frame *precv_frame)
>  {
>  	/* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
>