linux-kernel - Re: [PATCH] security/keys: BIG_KEY requires CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171005153914.GA19269@mail.hallyn.com>
Date:   Thu, 5 Oct 2017 10:39:14 -0500
From:   "Serge E. Hallyn" <serge@...lyn.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     David Howells <dhowells@...hat.com>,
        James Morris <james.l.morris@...cle.com>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Stephan Müller <smueller@...onox.de>,
        keyrings@...r.kernel.org, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] security/keys: BIG_KEY requires CONFIG_CRYPTO

Quoting Arnd Bergmann (arnd@...db.de):
> The recent rework introduced a possible randconfig build failure
> when CONFIG_CRYPTO configured to only allow modules:
> 
> security/keys/big_key.o: In function `big_key_crypt':
> big_key.c:(.text+0x29f): undefined reference to `crypto_aead_setkey'
> security/keys/big_key.o: In function `big_key_init':
> big_key.c:(.init.text+0x1a): undefined reference to `crypto_alloc_aead'
> big_key.c:(.init.text+0x45): undefined reference to `crypto_aead_setauthsize'
> big_key.c:(.init.text+0x77): undefined reference to `crypto_destroy_tfm'
> crypto/gcm.o: In function `gcm_hash_crypt_remain_continue':
> gcm.c:(.text+0x167): undefined reference to `crypto_ahash_finup'
> crypto/gcm.o: In function `crypto_gcm_exit_tfm':
> gcm.c:(.text+0x847): undefined reference to `crypto_destroy_tfm'
> 
> When we 'select CRYPTO' like the other users, we always get a
> configuration that builds.
> 
> Fixes: 428490e38b2e ("security/keys: rewrite all of big_key crypto")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Seems sensible, thanks.

Reviewed-by: Serge Hallyn <serge@...lyn.com>

> ---
>  security/keys/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/security/keys/Kconfig b/security/keys/Kconfig
> index 91eafada3164..6462e6654ccf 100644
> --- a/security/keys/Kconfig
> +++ b/security/keys/Kconfig
> @@ -45,6 +45,7 @@ config BIG_KEYS
>  	bool "Large payload keys"
>  	depends on KEYS
>  	depends on TMPFS
> +	select CRYPTO
>  	select CRYPTO_AES
>  	select CRYPTO_GCM
>  	help
> -- 
> 2.9.0