linux-kernel - Re: [PATCH 19/20] ARM: dts: sun9i: Change node names to remove underscores

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Oct 2017 23:56:29 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:     Chen-Yu Tsai <wens@...e.org>, Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 19/20] ARM: dts: sun9i: Change node names to remove underscores

On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> Some node names in the A80 DTSI still have underscores in them. Remove them
> in favour of hyphens to remove DTC warnings.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---
>  arch/arm/boot/dts/sun9i-a80.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> index f9cb701f29b0..70d79ef711b3 100644
> --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> @@ -139,7 +139,7 @@
>                  * would also throw all the PLL clock rates off, or just the
>                  * downstream clocks in the PRCM.
>                  */
> -               osc24M: osc24M_clk {
> +               osc24M: clk-24M {

Can we stick with the same style for all clks? Like "X-clk"?

>                         #clock-cells = <0>;
>                         compatible = "fixed-clock";
>                         clock-frequency = <24000000>;
> @@ -151,7 +151,7 @@
>                  * AC100 codec/RTC chip. This serves as a placeholder for
>                  * board dts files to specify the source.
>                  */
> -               osc32k: osc32k_clk {
> +               osc32k: clk-32k {

And here.

>                         #clock-cells = <0>;
>                         compatible = "fixed-factor-clock";
>                         clock-div = <1>;
> @@ -169,7 +169,7 @@
>                         clock-output-names = "cpus";
>                 };
>
> -               ahbs: ahbs_clk {
> +               ahbs: ahbs-clk {
>                         compatible = "fixed-factor-clock";
>                         #clock-cells = <0>;
>                         clock-div = <1>;
> @@ -708,12 +708,12 @@
>                         #interrupt-cells = <3>;
>                         #gpio-cells = <3>;
>
> -                       r_ir_pins: r_ir {
> +                       r_ir_pins: r-ir {

"r-ir-pins".

>                                 pins = "PL6";
>                                 function = "s_cir_rx";
>                         };
>
> -                       r_rsb_pins: r_rsb {
> +                       r_rsb_pins: r-rsb {

"r-rsb-pins".

ChenYu

>                                 pins = "PN0", "PN1";
>                                 function = "s_rsb";
>                                 drive-strength = <20>;
> --
> git-series 0.9.1