linux-kernel - Re: [PATCH] KVM: add X86_LOCAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Oct 2017 20:01:10 +0200
From:   Radim Krčmář <rkrcmar@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Juergen Gross <jgross@...e.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: add X86_LOCAL_APIC dependency

2017-10-04 12:28+0200, Arnd Bergmann:
> The rework of the posted interrupt handling broke building without
> support for the local APIC:
> 
> ERROR: "boot_cpu_physical_apicid" [arch/x86/kvm/kvm-intel.ko] undefined!
> 
> That configuration is probably not particularly useful anyway, so
> we can avoid the randconfig failures by adding a Kconfig dependency.

Yeah, and we can follow up by removing few ifdefs.

> Fixes: 8b306e2f3c41 ("KVM: VMX: avoid double list add with VT-d posted interrupts")

The offending cpu_physical_id() was there even before, so it is probably
the change of condition in pi_post_block that violated dead code
detection.

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Applied, thanks.