linux-kernel - Re: [PATCH] netfilter: ipset: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jJGiLDb1afVUsj=S=tA-WO1O-aJgmxz7706iC4QK9MxZg@mail.gmail.com>
Date:   Thu, 5 Oct 2017 11:15:40 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        Stephen Hemminger <stephen@...workplumber.org>,
        simran singhal <singhalsimran0@...il.com>,
        Muhammad Falak R Wani <falakreyaz@...il.com>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        Network Development <netdev@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] netfilter: ipset: Convert timers to use timer_setup()

On Thu, Oct 5, 2017 at 6:58 AM, Jozsef Kadlecsik
<kadlec@...ckhole.kfki.hu> wrote:
> Hi,
>
> On Wed, 4 Oct 2017, Kees Cook wrote:
>
>> In preparation for unconditionally passing the struct timer_list pointer
>> to all timer callbacks, switch to using the new timer_setup() and
>> from_timer() to pass the timer pointer explicitly. This introduces a
>> pointer back to the struct ip_set, which is used instead of the struct
>> timer_list .data field.
>
> Please add the same changes to net/netfilter/ipset/ip_set_list.c too, in
> order to handle all ipset modules in a single patch. I don't see a way
> either to avoid the introduction of the new pointer.

Ah yes, thanks. I'll send a v2 with that included.

-Kees

-- 
Kees Cook
Pixel Security