linux-kernel - Re: [PATCH v4 04/14] platform/x86: dell-wmi: increase severity of some failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vec=VX9CZSzBWDX5YCEKSoAn=B0403g+1Xhg4Jo5g00HA@mail.gmail.com>
Date:   Thu, 5 Oct 2017 21:22:31 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Mario Limonciello <Mario.Limonciello@...l.com>
Cc:     "dvhart@...radead.org" <dvhart@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>, quasisec@...gle.com,
        Pali Rohár <pali.rohar@...il.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>, mjg59@...gle.com,
        Christoph Hellwig <hch@....de>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH v4 04/14] platform/x86: dell-wmi: increase severity of
 some failures

On Thu, Oct 5, 2017 at 6:02 PM,  <Mario.Limonciello@...l.com> wrote:

>> > -       if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0)
>> > -               dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature
>> (%8ph)\n",
>> > +       if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) {
>> > +               dev_err(&wdev->dev, "Dell descriptor buffer has invalid signature
>> (%8ph)\n",
>>
>> A nit: ping-pong programming detected.
>> Looks like current patch 2 should go at least after this one.

> I'll re-order them, but either way both patches are touching these lines in some
> way.

Yeah, I noticed as well.

The rule of thumb is to arrange such small and non-so-important clean
ups at the tail of the series (as possible).

-- 
With Best Regards,
Andy Shevchenko