linux-kernel - Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1710052127320.2626@hadrien>
Date:   Thu, 5 Oct 2017 21:28:00 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Liam Breck <liam@...workimprov.net>
cc:     Joe Perches <joe@...ches.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Pali Rohár <pali.rohar@...il.com>,
        Linux PM mailing list <linux-pm@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Michal Marek <mmarek@...e.com>, cocci@...teme.lip6.fr,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kbuild test robot <fengguang.wu@...el.com>
Subject: Re: [PATCH] coccinelle: api: detect duplicate chip data arrays



On Thu, 5 Oct 2017, Liam Breck wrote:

> Hi Joe,
>
> On Thu, Oct 5, 2017 at 12:15 PM, Joe Perches <joe@...ches.com> wrote:
> > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote:
> >>
> >> On Fri, 6 Oct 2017, Masahiro Yamada wrote:
> >>
> >> > 2017-10-01 21:42 GMT+09:00 Julia Lawall <Julia.Lawall@...6.fr>:
> >> > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA
> >> > > within a single structure.  It is currently specific to the file
> >> > > drivers/power/supply/bq27xxx_battery.c.
> >> > >
> >> > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> >> > >
> >> > > ---
> >> >
> >> > Applied to linux-kbuild/misc.
> >>
> >> Thanks for picking it up.
> >
> > If it is specific to one file, why not just run it
> > and post the resultant patch?  Why have it in tree?
>
> The driver which this script analyzes supports more than a dozen
> different chips, which require different parameters. This script
> checks for duplicate parameter arrays.

I think the question is more how will the code change over time.

julia