linux-kernel - [PATCH 1/6] of: fix missing kobject init for !SYSFS && OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171005194422.26224-2-robh@kernel.org>
Date:   Thu,  5 Oct 2017 14:44:17 -0500
From:   Rob Herring <robh@...nel.org>
To:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc:     Nicolas Pitre <nico@...aro.org>,
        Frank Rowand <frowand.list@...il.com>,
        Grant Likely <glikely@...retlab.ca>
Subject: [PATCH 1/6] of: fix missing kobject init for !SYSFS && OF_DYNAMIC config

The ref counting is broken for OF_DYNAMIC when sysfs is disabled because
the kobject initialization is skipped. Only the properties
add/remove/update should be skipped for !SYSFS config.

Cc: Nicolas Pitre <nico@...aro.org>
Cc: Frank Rowand <frowand.list@...il.com>
Signed-off-by: Rob Herring <robh@...nel.org>
---
 drivers/of/base.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 260d33c0f26c..9e9bd17121fb 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -169,9 +169,6 @@ int __of_attach_node_sysfs(struct device_node *np)
 	struct property *pp;
 	int rc;
 
-	if (!IS_ENABLED(CONFIG_SYSFS))
-		return 0;
-
 	if (!of_kset)
 		return 0;
 
-- 
2.11.0