linux-kernel - Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1507233265.4434.45.camel@perches.com>
Date:   Thu, 05 Oct 2017 12:54:25 -0700
From:   Joe Perches <joe@...ches.com>
To:     Liam Breck <liam@...workimprov.net>
Cc:     Julia Lawall <julia.lawall@...6.fr>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Pali Rohár <pali.rohar@...il.com>,
        Linux PM mailing list <linux-pm@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>, cocci@...teme.lip6.fr,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kbuild test robot <fengguang.wu@...el.com>
Subject: Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

On Thu, 2017-10-05 at 12:46 -0700, Liam Breck wrote:
> Hi Joe,
> 
> On Thu, Oct 5, 2017 at 12:30 PM, Joe Perches <joe@...ches.com> wrote:
> > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote:
> > > On Thu, 5 Oct 2017, Joe Perches wrote:
> > > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote:
> > > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote:
> > > > > > 2017-10-01 21:42 GMT+09:00 Julia Lawall <Julia.Lawall@...6.fr>:
> > > > > > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA
> > > > > > > within a single structure.  It is currently specific to the file
> > > > > > > drivers/power/supply/bq27xxx_battery.c.
> > > > > > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> > > > > > 
> > > > > > Applied to linux-kbuild/misc.
> > > > > 
> > > > > Thanks for picking it up.
> > > > 
> > > > If it is specific to one file, why not just run it
> > > > and post the resultant patch?  Why have it in tree?
> > > 
> > > I guess that they anticipate that the data may change in the future?
> > 
> > Aren't you the script author Julia?  Who is the "they"?
> > 
> > I think having a script for a single file unnecessary.
> 
> Sebastian Reichel, the power-supply maintainer, requested this script.
> I previously implemented this as a run-time check within ifdef DEBUG,
> but that was rejected.

Hi Liam.

If you are the author of the script, you should also have
a sign-off/from here right?

This also has a copyright of Inria and Julia Lawall
which, if you are the author, doesn't seem appropriate.

cheers, Joe