linux-kernel - Re: [PATCH] kbuild: revert $(realpath ...) to $(shell cd ... && /bin/pwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNARStcxr=Htuje15+Hh0mZ_km42j8V1LQ=nYyqGKvuKWXA@mail.gmail.com>
Date:   Fri, 6 Oct 2017 05:17:01 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Julien Grall <julien.grall@....com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux PM mailing list <linux-pm@...r.kernel.org>,
        Michal Marek <mmarek@...e.com>,
        David Carrillo-Cisneros <davidcc@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Renninger <trenn@...e.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH] kbuild: revert $(realpath ...) to $(shell cd ... && /bin/pwd)

2017-10-02 20:27 GMT+09:00 Julien Grall <julien.grall@....com>:
> Hello,
>
> On 02/10/17 09:07, Masahiro Yamada wrote:
>>
>> I thought commit 8e9b46679923 ("kbuild: use $(abspath ...) instead of
>> $(shell cd ... && /bin/pwd)") was a safe conversion, but it changed
>> the behavior.
>>
>> $(abspath ...) / $(realpath ...) does not expand shell special
>> characters, such as '~'.
>>
>> Here is a simple Makefile example:
>>
>>    ---------------->8----------------
>>    $(info /bin/pwd: $(shell cd ~/; /bin/pwd))
>>    $(info abspath: $(abspath ~/))
>>    $(info realpath: $(realpath ~/))
>>    all:
>>            @:
>>    ---------------->8----------------
>>
>>    $ make
>>    /bin/pwd: /home/masahiro
>>    abspath: /home/masahiro/workspace/~
>>    realpath:
>>
>> This can be a real problem if 'make O=~/foo' is invoked from another
>> Makefile or primitive shell like dash.
>>
>> This commit partially reverts 8e9b46679923.
>>
>> Fixes: 8e9b46679923 ("kbuild: use $(abspath ...) instead of $(shell cd ...
>> && /bin/pwd)")
>> Reported-by: Julien Grall <julien.grall@....com>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>
>
> Tested-by: Julien Grall <julien.grall@....com>


Applied to linux-kbuild/fixes.


-- 
Best Regards
Masahiro Yamada