linux-kernel - Re: [PATCH 1/2] powerpc/platforms/cell: Delete an error message for a failed memory allocation in three functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171005222949.3a288238@kitsune.suse.cz>
Date:   Thu, 5 Oct 2017 22:29:49 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Arnd Bergmann <arnd@...db.de>, kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Paul Mackerras <paulus@...ba.org>, Jeremy Kerr <jk@...abs.org>,
        linuxppc-dev@...ts.ozlabs.org,
        SF Markus Elfring <elfring@...rs.sourceforge.net>
Subject: Re: [PATCH 1/2] powerpc/platforms/cell: Delete an error message for
 a failed memory allocation in three functions

On Thu, 5 Oct 2017 22:06:11 +0200 (CEST)
Julia Lawall <julia.lawall@...6.fr> wrote:

> On Thu, 5 Oct 2017, Michal Suchánek wrote:
> 
> > Hello,
> >
> > On Thu, 5 Oct 2017 21:36:26 +0200
> > SF Markus Elfring <elfring@...rs.sourceforge.net> wrote:
> >  
> > > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > > Date: Thu, 5 Oct 2017 21:04:30 +0200
> > >
> > > Omit extra messages for a memory allocation failure in these
> > > functions.  
> >
> > this is bogus. All these functions return -1 on any error. Until
> > they reflect the error in their return value (and it is properly
> > propagated to the user) there is no way to tell WTF failed without
> > the message.  
> 
> A backtrace will be generated.
> 

I do not see why it would. I do not expect the kernel to generate a
stack trace every time memory allocation fails. With all the hooks in
the code it is hard to tell, though.

Thanks

Michal