linux-kernel - Re: [PATCH] spi: spreadtrum adi: add hwspinlock dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0gh05qL8ez0mmPB-UCcWQmyHGMvU-XKgKCQPNGAcFJ4w@mail.gmail.com>
Date:   Thu, 5 Oct 2017 22:40:11 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Mark Brown <broonie@...nel.org>
Cc:     Baolin Wang <baolin.wang@...eadtrum.com>,
        linux-spi <linux-spi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: spreadtrum adi: add hwspinlock dependency

On Thu, Oct 5, 2017 at 2:22 PM, Mark Brown <broonie@...nel.org> wrote:
> On Thu, Oct 05, 2017 at 02:11:17PM +0200, Arnd Bergmann wrote:
>
>> This adds a hard Kconfig dependency on HWSPINLOCK, which is the
>> simplest solution since we don't care about building for the case
>> without HWSPINLOCK.
>
> Given that there are stubs for HWSPINLOCK it'd be good to also have an
> || COMPILE_TEST in there, otherwise what's the point in the stubs?

As far as I'm concerned, we can remove those stubs, it's easy enough
to compile-test with hwspinlock enabled, and the existing in-kernel
users all require hwspinlock anyway.

I've sent a second version now, please pick whichever you prefer.

     Arnd