linux-kernel - Re: [PATCH 05/20] ARM: dts: sun4i: Change pinctrl nodes to avoid warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Oct 2017 10:45:27 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/20] ARM: dts: sun4i: Change pinctrl nodes to avoid
 warning

Hi,

On Thu, Oct 05, 2017 at 03:29:56PM +0000, Chen-Yu Tsai wrote:
> > @@ -531,83 +531,83 @@
> >                                 bias-pull-up;
> >                         };
> >
> > -                       ps20_pins_a: ps20@0 {
> > -                               pins = "PI20", "PI21";
> > +                       ps2_ph_pins: ps2-ph-pins {
> > +                               pins = "PH12", "PH13";
> >                                 function = "ps2";
> >                         };
> >
> > -                       ps21_pins_a: ps21@0 {
> > -                               pins = "PH12", "PH13";
> > +                       ps2_pi_pins: ps2-pi-pins {
> > +                               pins = "PI20", "PI21";
> >                                 function = "ps2";
> >                         };
> 
> This part is slightly incorrect. The PS/2 block has 2 inputs.
> The first channel, or ps2-0, has only one muxing option, on
> pins PI20 and PI21. The second channel has two options, either
> PH12 + PH13 or PI14 + PI15. The names should encode which channel
> the muxing option is for.

Would ps2_ch0_pins and ps2_ch1_pi_pins work for you then?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)