linux-kernel - Re: [PATCH v3 1/4] phy: rcar-gen3-usb2: check dr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171006091550.GE7734@verge.net.au>
Date:   Fri, 6 Oct 2017 11:15:50 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc:     kishon@...com, linux-kernel@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v3 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

On Fri, Sep 01, 2017 at 11:41:22AM +0900, Yoshihiro Shimoda wrote:
> The previous code assumed a channel has otg capability if a channel
> has interrupt property. But, it is not good because:
>  - Battery charging feature also needs interrupt property.
>  - Some R-Car Gen3 SoCs (e.g. R-Car D3) don't have OTG capability.
> 
> So, this patch checks whether usb 2.0 host node has dr_mode property or
> not. If it has 'dr_mode = "otg";', this driver enables otg capability.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>