linux-kernel - Re: [PATCH] arch_topology: Fix section miss match warning due to free_raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44861c45841cc1dbc1ecac5df495ce35@codeaurora.org>
Date:   Thu, 05 Oct 2017 18:40:23 -0700
From:   Sodagudi Prasad <psodagud@...eaurora.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>, gregkh@...uxfoundation.org
Cc:     gregkh@...uxfoundation.org, juri.lelli@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch_topology: Fix section miss match warning due to
 free_raw_capacity()

On 2017-09-25 16:20, Viresh Kumar wrote:
> On 25-09-17, 15:51, Prasad Sodagudi wrote:
>> Remove the __init annotation from free_raw_capacity() to avoid
>> the following warning.
>> 
>> The function init_cpu_capacity_callback() references the
>> function __init free_raw_capacity().
>> WARNING: vmlinux.o(.text+0x425cc0): Section mismatch in reference
>> from the function init_cpu_capacity_callback() to the function
>> .init.text:free_raw_capacity().
>> 
>> Signed-off-by: Prasad Sodagudi <psodagud@...eaurora.org>
>> ---
>>  drivers/base/arch_topology.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/base/arch_topology.c 
>> b/drivers/base/arch_topology.c
>> index 41be9ff..3da53cc 100644
>> --- a/drivers/base/arch_topology.c
>> +++ b/drivers/base/arch_topology.c
>> @@ -96,7 +96,7 @@ static int register_cpu_capacity_sysctl(void)
>>  static u32 capacity_scale;
>>  static u32 *raw_capacity;
>> 
>> -static int __init free_raw_capacity(void)
>> +static int free_raw_capacity(void)
>>  {
>>  	kfree(raw_capacity);
>>  	raw_capacity = NULL;
> 
> So we need the __init thing only when cpufreq support isn't there in 
> the kernel
> and I am not sure if we want to add more ifdef hackery in the 
> declaration of
> free_raw_capacity().
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
Hi Greg,

  Can you please consider this patch ?

-Thanks, Prasad
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
Linux Foundation Collaborative Project