linux-kernel - Re: [PATCH] lightnvm: pblk: remove spinlock when freeing line metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3ECEB320-3133-4E85-90EA-1F8AAD597ED6@lightnvm.io>
Date:   Fri, 6 Oct 2017 15:28:44 +0200
From:   Javier González <jg@...htnvm.io>
To:     Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc:     Hans Holmberg <hans.ml.holmberg@...tronix.com>,
        Matias Bjørling <mb@...htnvm.io>,
        linux-block@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hans Holmberg <hans.holmberg@...xlabs.com>
Subject: Re: [PATCH] lightnvm: pblk: remove spinlock when freeing line
 metadata

> On 6 Oct 2017, at 11.20, Andrey Ryabinin <aryabinin@...tuozzo.com> wrote:
> 
> On 10/05/2017 11:35 AM, Hans Holmberg wrote:
>> From: Hans Holmberg <hans.holmberg@...xlabs.com>
>> 
>> Lockdep complains about being in atomic context while freeing line
>> metadata - and rightly so as we take a spinlock and end up calling
>> vfree that might sleep(in pblk_mfree).
>> 
>> There is no need for holding the line manager free_lock while
>> freeing line metadata, so remove the lock.
>> 
>> Signed-off-by: Hans Holmberg <hans.holmberg@...xlabs.com>
> 
> Reviewed-by: Andrey Ryabinin <aryabinin@...tuozzo.com>
> 
> I guess this also deserves stable tag. The bug was introduced in 4.13 by
> commit 588726d3ec68 ("lightnvm: pblk: fail gracefully on irrec. error").
> 

Good point. We'll add it when picking it up.

Thanks,
Javier

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)