linux-kernel - Re: [PATCH 2/6] of: remove struct property.unique

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACxGe6tw6F4AEU0FdR2Y_V-Ka0mXsm_i6K8nU18jjKQRwUB+Sg@mail.gmail.com>
Date:   Fri, 6 Oct 2017 14:30:01 +0100
From:   Grant Likely <glikely@...retlab.ca>
To:     Rob Herring <robh@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Nicolas Pitre <nico@...aro.org>,
        Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH 2/6] of: remove struct property.unique_id for FDT

On Thu, Oct 5, 2017 at 8:44 PM, Rob Herring <robh@...nel.org> wrote:
> Only Sparc uses unique_id, so remove it for FDT builds and shrink struct
> property a bit making the unflattened DT less of a memory hog.

It can be even more constrained than that. I think the only user is
openpromfs so you could make it depend on CONFIG_SUN_OPENPROMFS, and
adjust the needed code in pdt.c.

Ideally, I'd like to be rid of unique_id entirely, but that's a much
more invasive patch set. Regardless:

Acked-by: Grant Likely <grant.likely@...retlab.ca>

(That goes for the entire series)

>
> Cc: Nicolas Pitre <nico@...aro.org>
> Cc: Frank Rowand <frowand.list@...il.com>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  include/linux/of.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index cfc34117fc92..8f9e96752837 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -38,7 +38,9 @@ struct property {
>         void    *value;
>         struct property *next;
>         unsigned long _flags;
> +#if defined(CONFIG_OF_PROMTREE)
>         unsigned int unique_id;
> +#endif
>         struct bin_attribute attr;
>  };
>
> --
> 2.11.0
>